Match summary pages not displaying #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeninski
reviewed
Jan 11, 2021
src/views/MatchDetail.vue
Outdated
| player.battleTag.startsWith(s.battleTag) | ||
| ) | ||
| ); | ||
| ) | ||
| .map((s) => { |
There was a problem hiding this comment.
Can you extract this into a function with some parameters cuz it seems like alot of duplicated code:
full/partial battleTag match, winner/loser
There was a problem hiding this comment.
@abeninski PR has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#317
Add logic to handle incomplete battle tags. The issue is caused by incorrect battletag data stored in the database (i.e. 'iDentify' is in the db, but it should be
iDentify#11833). The new logic will attempt to match the player if no matching battletag is found.w3champions/w3champions-statistic-service/#113