chore: update docs to show new property #209
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -64,14 +64,11 @@ const peers = [ | |||
|
|
|||
| const node = await createLightNode(); | |||
|
|
|||
| // In case nodes are using `ws` protocol - additional configuration is needed: | |||
| // In case nodes are using IP address and / or `ws` protocol - additional configuration is needed: | |||
There was a problem hiding this comment.
What does IP Address mean here?
Perhaps saying:
In case you want to also connect to nodes that support only insecure websockets, ie, the
wsprotocol -- we recommend using the following configuration to allow your node to also connect with other nodes over insecure websocket connection:
There was a problem hiding this comment.
It meant IP maddr format like "/ip4/0.0.0.0/tcp/60002/ws/p2p/16Uiu2HAkzjwwgEAXfeGNMKFPSpc6vGBRqCdTLG5q3Gmk2v4pQw7H"
The thing is if filter applied - it ignores ip addresses too (wss cannot be established without domain name)
There was a problem hiding this comment.
Correct, because domain names would mean there is a SSL setup.
Re the docs: feel free to frame it as you want & merge :)
|
@weboko please update branch and I can merge. |
This PR is follow up to waku-org/js-waku#2103