chore: enable back filterAll if set by consumer #2103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #1989 we made it so
fitlerAll
is applied only in tests.Reasoning for it was that in running dogfooding apps we were seeing a lot of errors and we wanted to prevent light node trying to establish a connection that will definitely fail.
But it prevents local development with js-waku so that locally run nodes or nodes run under IP - are ignored and connection is not established or event attempted.
Solution
Add
fitlerMultiaddrs
flag tolibp2p
configuration so that is it is set tofalse
- then such behavior is off.Notes