Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update all references of shard info to RFC terminology #1740

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Nov 29, 2023

This PR changes all references of cluster and index/indexList with the RFC terminologies clusterId and shard/shards

Notes

@danisharora099 danisharora099 requested a review from a team as a code owner November 29, 2023 07:34
@danisharora099 danisharora099 mentioned this pull request Nov 29, 2023
1 task
Copy link

github-actions bot commented Nov 29, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 78.38 KB (0%) 1.6 s (0%) 1.5 s (-30.55% 🔽) 3.1 s
Waku Simple Light Node 240.9 KB (0%) 4.9 s (0%) 3.9 s (+24.85% 🔺) 8.8 s
ECIES encryption 72.85 KB (0%) 1.5 s (0%) 1.3 s (-3.45% 🔽) 2.8 s
Symmetric encryption 72.83 KB (0%) 1.5 s (0%) 1.2 s (-51.83% 🔽) 2.6 s
DNS discovery 120.85 KB (0%) 2.5 s (0%) 2.8 s (+10.62% 🔺) 5.2 s
Privacy preserving protocols 125.75 KB (0%) 2.6 s (0%) 1.4 s (-56.79% 🔽) 3.9 s
Light protocols 75.95 KB (0%) 1.6 s (0%) 1.6 s (+29.17% 🔺) 3.1 s
History retrieval protocols 74.86 KB (0%) 1.5 s (0%) 1.6 s (-11.88% 🔽) 3.1 s
Deterministic Message Hashing 5.65 KB (0%) 113 ms (0%) 297 ms (-3.64% 🔽) 410 ms

Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danisharora099 danisharora099 force-pushed the chore/shardinfo-terminology-rfc branch from a51042c to 55a4ffa Compare November 29, 2023 10:18
@danisharora099 danisharora099 merged commit bbd3721 into master Nov 29, 2023
9 of 11 checks passed
@danisharora099 danisharora099 deleted the chore/shardinfo-terminology-rfc branch November 29, 2023 12:08
danisharora099 added a commit that referenced this pull request Nov 29, 2023
* update all references of shard info to RFC terminology

* bump nwaku to v0.22.0 (#1741)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants