chore: fix encoder/decoder creation #1742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With #1697, setting pubsub topic based on
shardInfo
was introduced.a bug was spotted during property check where if the
index
is0
, it falls back to theDefaultPubsubTopic
.Solution
The PR removes the property check, and just checks the definition on
pubsubTopicShardInfo
Another solution could be to add a specific
unedefined
check like:pubsubTopicShardInfo !== undefined
but there are very little benefits of additional property checking on a type-safe system. (ref: #1697 (comment))