Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(libwaku): ping peer #3144

Merged
merged 2 commits into from
Oct 24, 2024
Merged

feat(libwaku): ping peer #3144

merged 2 commits into from
Oct 24, 2024

Conversation

richard-ramos
Copy link
Member

Description

Adds a function to ping peers via bindings

int waku_ping_peer(void* ctx,
                        const char* peerAddr,
                        int timeoutMs,
                        WakuCallBack callback,
                        void* userData);

This is required in status-go for the storenode cycle, in which a storenode is selected based on ping RTT

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3144

Built from 3198378

Ivansete-status
Ivansete-status approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for it! 🙌

library/waku_thread/inter_thread_communication/requests/ping_request.nim Outdated Show resolved Hide resolved
gabrielmer
gabrielmer approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@richard-ramos @Ivansete-status
fix: let
7c2893d 
Co-authored-by: Ivan FB <[email protected]>
@richard-ramos richard-ramos merged commit de11e57 into master Oct 24, 2024
9 of 11 checks passed
@richard-ramos richard-ramos deleted the libwaku/pingpeer branch October 24, 2024 13:07
@richard-ramos richard-ramos mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

@NagyZoltanPeter NagyZoltanPeter Awaiting requested review from NagyZoltanPeter

Assignees

@richard-ramos richard-ramos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-ramos @gabrielmer @Ivansete-status