JayLara Homework Submission -base #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BritneyJo
reviewed
Sep 20, 2017
| } | ||
|
|
||
| body { | ||
| width: 900px; |
There was a problem hiding this comment.
Setting the width with a hardcoded px value will make this site unresponsive. Try using margin or % instead.
| h1 { | ||
| font-size: 65px; | ||
| padding: 0px; | ||
| margin: 10px 0px; |
There was a problem hiding this comment.
Whenever you are using 0 as a value you do not need to specify the units. 0px = 0% = 0.
| margin: 10px 0px; | ||
| } | ||
|
|
||
| h1 a { |
| color: #eae2de; | ||
| font-size: 40px; | ||
| padding: 0px; | ||
| margin: 70px 0px 10px 0px; |
There was a problem hiding this comment.
Shorthand way to write this is margin: 70px 0 10px.
|
|
||
| img { width: 100%;} | ||
| article { | ||
| width: 850px; |
There was a problem hiding this comment.
Again, set the width with a % so that you are not limiting your site to break on a mobile device.
| line-height: 26px; | ||
| } | ||
|
|
||
| article p::first-letter { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.