Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JayLara Homework Submission -base #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

JayLara Homework Submission -base #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b43ecb4
JayLara Homework Submission -base
jaylara Sep 14, 2017
4dc4f64
Jay Lara Homework Submission - base
Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions starter-code/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
* {
font-family: 'Lato', sans-serif;
font-weight: 300;
}

body {
width: 900px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the width with a hardcoded px value will make this site unresponsive. Try using margin or % instead.

margin: 0 auto;
}

a {
text-decoration: none;
}

h1 {
font-size: 65px;
padding: 0px;
margin: 10px 0px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you are using 0 as a value you do not need to specify the units. 0px = 0% = 0.

}

h1 a {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch your indentations!

color: #f8ce78;
letter-spacing: -2px;
}

h2 {
padding: 0px;
margin: 10px 0px;
font-size: 25px;
}

img { width: 100%;}
article {
width: 850px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, set the width with a % so that you are not limiting your site to break on a mobile device.

border-bottom: 3px solid #eae2de;
margin-bottom: 65px;
}

article p {
line-height: 26px;
}

article p::first-letter {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

float: left;
padding: 0 5px 0 0;
color: #eae2de;
font-size: 110px;
line-height: 80px;
font-weight: 300;
}

article h2 a {
color: black;
font-size: 40px;
}

article h3 {
color: #eae2de;
font-size: 40px;
padding: 0px;
margin: 70px 0px 10px 0px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorthand way to write this is margin: 70px 0 10px.

}


article h4 a {
text-align: right;
color: #f8ce78;
padding: 15px 0;
display: block;
font-weight: bold;
font-size: 18px;
}

nav {
margin: 20px 0px;
display: block;
}

header nav a {
color: #eae2de;
font-size: 20px;
margin-right: 20px;
padding-bottom: 5px;
border-bottom: 2px solid #eae2de;
}

footer {
color: #eae2de;
font-size: 20px;
}

footer nav {
line-height: 22px;
}

footer nav a {
color: #f8ce78;
}
2 changes: 1 addition & 1 deletion starter-code/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!doctype html>
<!doctype html>
<html lang="en-us">
<head>
<meta charset="utf-8">
Expand Down