fix: do not use cacheUnaffected for side-effects-flag-plugin

web-infra-dev · Sep 11, 2024 · 6480efb · 6480efb
1 parent 78041b8
commit 6480efb
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 36 deletions.
diff --git a/crates/rspack_plugin_javascript/src/plugin/side_effects_flag_plugin.rs b/crates/rspack_plugin_javascript/src/plugin/side_effects_flag_plugin.rs
@@ -656,38 +656,13 @@ async fn nmf_module(
 
 #[plugin_hook(CompilationOptimizeDependencies for SideEffectsFlagPlugin)]
 fn optimize_dependencies(&self, compilation: &mut Compilation) -> Result<Option<bool>> {
-  let affected_modules = compilation
-    .unaffected_modules_cache
-    .get_affected_modules_with_chunk_graph()
-    .lock()
-    .expect("should lock")
-    .clone();
-  dbg!(affected_modules);
   // TODO: use affected module optimization
   let mut modules: IdentifierSet = compilation
     .get_module_graph()
     .modules()
     .keys()
     .copied()
     .collect();
-
-  let mut modules: IdentifierSet = if compilation.options.new_incremental_enabled() {
-    compilation
-      .unaffected_modules_cache
-      .get_affected_modules_with_module_graph()
-      .lock()
-      .expect("should lock")
-      .iter()
-      .copied()
-      .collect()
-  } else {
-    compilation
-      .get_module_graph()
-      .modules()
-      .keys()
-      .copied()
-      .collect()
-  };
   let mut new_connections = Default::default();
   for module in modules.clone() {
     optimize_incoming_connections(module, &mut modules, &mut new_connections, compilation);

diff --git a/...tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/index.js b/...tools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/index.js
@@ -1,4 +1,4 @@
-import {v as value} from "./module";
+import {value} from "./module";
 
 let v = value;
 module.hot.accept('./module', () => {

diff --git a/...ools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/module.js b/...ools/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/module.js
@@ -1,7 +1,6 @@
 import {v} from './reexports'
-v;
-export {v};
-----
+//
+export const value = '' + v;
+---
 import {v} from './reexports'
-v;// no-op
-export {v};
+export const value = '' + v;
diff --git a/...s/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/package.json b/...s/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/package.json
@@ -1,3 +1 @@
-{
-  "sideEffects": false
-}
+{}
diff --git a/...s/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/reexports.js b/...s/tests/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/reexports.js
@@ -1,2 +1 @@
-import {v} from './reexports-deep';
-export {v};
+export { v } from "./reexports-deep";
diff --git a/...sts/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/rspack.config.js b/...sts/hotCases/newTreeshaking/re-export-optimization-for-inaffected-module/rspack.config.js
@@ -3,5 +3,10 @@ module.exports = {
 	optimization: {
 		sideEffects: true,
 		providedExports: true,
+	},
+	experiments: {
+		rspackFuture: {
+			newIncremental: true
+		}
 	}
 };