fix: try to fix the random test failed of rspack-cli

web-infra-dev · Sep 30, 2024 · fca794e · fca794e
1 parent a193dcd
commit fca794e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/rspack-cli/tests/build/issue-6359/index.test.ts b/packages/rspack-cli/tests/build/issue-6359/index.test.ts
@@ -10,6 +10,8 @@ it("should not have `process.env.WEBPACK_SERVE` set on build mode", async () =>
 
 it("should have `process.env.WEBPACK_SERVE` set on serve mode", async () => {
 	await runWatch(__dirname, ["serve"], { killString: /rspack compiled/i });
+	// wait 1s to make sure the assets have been generated
+	await new Promise(resolve => setTimeout(resolve, 1000));
 	const mainJs = await readFile(resolve(__dirname, "dist/main.js"), "utf-8");
 
 	expect(mainJs).toContain("WEBPACK_SERVE=true");

diff --git a/packages/rspack-cli/tests/build/issue-6359/rspack.config.js b/packages/rspack-cli/tests/build/issue-6359/rspack.config.js
@@ -1,5 +1,4 @@
 const path = require("path");
-const { WEBPACK_SERVE } = process.env;
 module.exports = /** @type {import('@rspack/cli').Configuration} */ {
 	mode: "production",
 	entry: "./entry.js",
@@ -12,7 +11,7 @@ module.exports = /** @type {import('@rspack/cli').Configuration} */ {
 			apply(compiler) {
 				new compiler.webpack.DefinePlugin({
 					DEFINE_ME: JSON.stringify(
-						`WEBPACK_SERVE=${WEBPACK_SERVE ?? "<EMPTY>"}`
+						`WEBPACK_SERVE=${process.env.WEBPACK_SERVE ?? "<EMPTY>"}`
 					)
 				}).apply(compiler);
 			}