Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(typescript): packages/rspack/src/lib from js to ts and esm #7289

Merged
merged 10 commits into from
Jul 29, 2024
Merged

refactor(typescript): packages/rspack/src/lib from js to ts and esm #7289

merged 10 commits into from
Jul 29, 2024

Conversation

shulaoda
Copy link
Collaborator

Summary

Related to #7225

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda marked this pull request as draft July 23, 2024 16:21
@shulaoda shulaoda marked this pull request as ready for review July 23, 2024 19:49
@SoonIter SoonIter self-assigned this Jul 24, 2024
@SoonIter
Copy link
Member

@shulaoda could you check your qq email? 😄 @Timeless0911 sends a email to you

@shulaoda
Copy link
Collaborator Author

Ready to merge in? If ready, I will update the branch. @SoonIter

@SoonIter
Copy link
Member

Ready to merge in? If ready, I will update the branch. @SoonIter

reviewing, on the way

@SoonIter
Copy link
Member

currently, the git status is not rename , it is difficult for me to review and not friendly to git history...
image

so I need to push --force one commit with rename status by git mv

@netlify Netlify
Copy link

netlify bot commented Jul 29, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit f8d8abc
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66a791259c016d0007834773

@SoonIter
Copy link
Member

https://github.com/web-infra-dev/rspack/pull/7289/files/1bc8798593f2c93678fff2b7ea1e22dfaaeabbe5..2e4398453357dafad2a9557c64f77d40a1c61ebc#diff-5eba14dafadd5b7ee447411919692ad06f841b6b93770e131cc6b364771f68b5

😉OK, it looks good now

@SoonIter SoonIter mentioned this pull request Jul 29, 2024
Closed
@SoonIter SoonIter enabled auto-merge (squash) July 29, 2024 13:25
@SoonIter SoonIter merged commit ebf8483 into web-infra-dev:main Jul 29, 2024
28 checks passed
@SoonIter
Copy link
Member

thanks~ 🫰🏻

@shulaoda shulaoda deleted the refactor/ts-rspack-src-lib branch July 29, 2024 15:41
@chenjiahan chenjiahan mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoonIter SoonIter SoonIter approved these changes

Assignees

@SoonIter SoonIter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shulaoda @SoonIter