[Tracking]: JS -> TS refactor the remaining .js file to .ts and esm

[SoonIter]

What subject does this issue tracking?

JS -> TS

1. refactor the remaining .js file to .ts
2. remove all ts-expect-error
3. use typescript rather than JSDocs
4. It is best not to use default imports or exports, "module": "nodenext" causes dynamic imports to be double default-wrapped - e.g. { default: { default: Foo } } microsoft/TypeScript#59257
5. aligned with webpack

#4640

Rename to .ts file

Beta Give feedback

1. refactor: remove identifier.js ts-expect-error #7132
   +0
2. refactor: remove ErrorHelpers.js ts-expect-error #7136
   +0
3. packages/rspack/src/ModuleTypeConstants.js & packages/rspack/src/Template.js
4. packages/rspack/src/lib
5. packages/rspack/src/config
6. packages/rspack/src/util
7. packages/rspack/src/loader-runner
8. packages/rspack/src/builtin-plugin/css-extract/hmr
9. packages/rspack-dev-server/src/ansiHTML.js

Type Coverage

Increase type coverage

Beta Give feedback

1. src/lib/formatLocation.ts
2. src/logging/runtime.ts
3. src/util/webpack.ts
4. src/logging/truncateArgs.ts
5. src/node/nodeConsole.ts
6. src/builtin-plugin/EnableWasmLoadingPlugin.ts
7. src/builtin-plugin/EnableChunkLoadingPlugin.ts
8. src/util/memoize.ts
9. src/stats/StatsFactory.ts

---- 2024.09.21

Our main files have been completed, and on this basis, we can do some work to increase the type coverage

type coverage contribution guide is in #7225 (comment)

this issues is closed, but any pr that increases the type coverage is acceptable.

[SoonIter]

A very huge task, pr welcome~ :D

[SoonIter]

Use https://github.com/alexcanessa/typescript-coverage-report to count the typescript coverage

Before

After #7289

Still remaining some ts files

our goal is reach >= 97%, so if you are interested in fixing some typescript any problem, also pr welcome ~

[wxiaoyun]

I will work on src/stats/StatsFactory.ts @shulaoda

[shulaoda]

I will work on src/stats/StatsFactory.ts @shulaoda

I am working on src/logging/truncateArgs.ts 👀

[wxiaoyun]

Thanks for leaving utils/webpack
Please let me work on it ❤️

[wxiaoyun]

I will work on src/node/nodeConsole.ts as well ❤️

[SoonIter]

after #7437

our type coverage reach 95.38%, type coverage of each file >= 80%

👏🏻👏🏻👏🏻Thank you all

any pull request to increase type coverage is acceptable

type coverage contribution guide

1. run pnpm install cd ./packages/rspack
2. run npx typescript-coverage-report
3. view files with low type coverage to contribute

[shulaoda]

type coverage contribution guide

1. run pnpm install
2. run pnpm run type-coverage
3. view files with low type coverage to contribute

Should we add a script in package.json?

[SoonIter]

Should we add a script in package.json?

Sorry, updated with npx typescript-coverage-report

[Technologeek]

Hey @SoonIter Still relevant to increase the type coverage for some of the files mentioned?

[shulaoda]

Hey @SoonIter Still relevant to increase the type coverage for some of the files mentioned?

Welcome, try to do it.

[SoonIter]

Hey @SoonIter Still relevant to increase the type coverage for some of the files mentioned?

yeah, pr welcome

[pawel-twardziak]

Is there anything left to work on here? :)

[SoonIter]

Is there anything left to work on here? :)

Yeah, we can increase the type coverage according to #7225 (comment)

[SoonIter]

this issues is closed, but any pr that increases the type coverage is acceptable.