-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Show partitioned cookies in testdriver.{get_named_cookie, get_all_cookies} #52106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a98b643 to
88b4e2d
Compare
…kies} These functions were previously unable to read partitioned cookies. I filed w3c/webdriver#1893 to address this on the WebDriver spec level and would strongly expect other browsers to match that behavior. Change-Id: I6af3287e3ae955110aed4513051712583ff86949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6458981 Reviewed-by: Mike West <[email protected]> Commit-Queue: Johann Hofmann <[email protected]> Cr-Commit-Position: refs/heads/main@{#1451763}
88b4e2d to
1f6f61e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes: This request requires the client to satisfy the following scope expression:
|
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes: This request requires the client to satisfy the following scope expression:
|
|
This PR is failing cc @johannhof |
936b5d0 to
b7388e7
Compare
These functions were previously unable to read partitioned cookies.
I filed w3c/webdriver#1893 to address this
on the WebDriver spec level and would strongly expect other browsers to
match that behavior.
Change-Id: I6af3287e3ae955110aed4513051712583ff86949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6458981
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Johann Hofmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1451763}