Skip to content

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 22, 2025

These functions were previously unable to read partitioned cookies.
I filed w3c/webdriver#1893 to address this
on the WebDriver spec level and would strongly expect other browsers to
match that behavior.

Change-Id: I6af3287e3ae955110aed4513051712583ff86949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6458981
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Johann Hofmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1451763}

…kies}

These functions were previously unable to read partitioned cookies.
I filed w3c/webdriver#1893 to address this
on the WebDriver spec level and would strongly expect other browsers to
match that behavior.

Change-Id: I6af3287e3ae955110aed4513051712583ff86949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6458981
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Johann Hofmann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1451763}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@community-tc-integration
Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/CRYc7iGOQIe35qiVlGxIig/Xa91T3hwRjmx03w94aQJCQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/CRYc7iGOQIe35qiVlGxIig"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/CRYc7iGOQIe35qiVlGxIig/Xa91T3hwRjmx03w94aQJCQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/CRYc7iGOQIe35qiVlGxIig"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-04-25T20:42:25.586Z

@community-tc-integration
Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/CRYc7iGOQIe35qiVlGxIig/HLZw0MB5T-W5JjRVlQMeew",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/CRYc7iGOQIe35qiVlGxIig"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/CRYc7iGOQIe35qiVlGxIig/HLZw0MB5T-W5JjRVlQMeew",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/CRYc7iGOQIe35qiVlGxIig"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-04-25T20:42:25.731Z

@jonathan-j-lee
Copy link
Contributor

This PR is failing infrastructure/ tests, which are essentially an E2E test of the runner/JS resources. The check happens to use a version of Firefox that apparently doesn't support partitioned cookies, so I'll unblock this PR by adding expectations recording the new failures.

cc @johannhof

@jonathan-j-lee jonathan-j-lee force-pushed the chromium-export-cl-6458981 branch from 936b5d0 to b7388e7 Compare April 26, 2025 00:22
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0dbee95 into master Apr 26, 2025
21 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-6458981 branch April 26, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants