Skip to content

Show partitioned cookies in testdriver.{get_named_cookie, get_all_cookies} #52106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025
Merged

Show partitioned cookies in testdriver.{get_named_cookie, get_all_cookies} #52106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f6f61e
Show partitioned cookies in testdriver.{get_named_cookie, get_all_coo…
johannhof Apr 25, 2025
b7388e7
Add `infrastructure/` expectations for getting partitioned cookies
jonathan-j-lee Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions infrastructure/metadata/infrastructure/testdriver/get_all_cookies.sub.https.html.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[get_all_cookies.sub.https.html]
[Get all HTTPS cookies]
expected:
# WPT CI uses a `firefox` version that doesn't support partitioned cookies
if product == "firefox" or product == "firefox_android": FAIL
5 changes: 5 additions & 0 deletions infrastructure/metadata/infrastructure/testdriver/get_named_cookie.sub.https.html.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[get_named_cookie.sub.https.html]
[Get Named HTTPS cookie]
expected:
# WPT CI uses a `firefox` version that doesn't support partitioned cookies
if product == "firefox" or product == "firefox_android": FAIL
13 changes: 12 additions & 1 deletion infrastructure/testdriver/get_all_cookies.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
document.cookie = "test5=5; SameSite=Strict";
document.cookie = "test6=6; SameSite=None; Secure";
document.cookie = "test7=7; SameSite=Lax";
document.cookie = "test8=8; Secure; Partitioned; SameSite=None";
const cookies = await test_driver.get_all_cookies();
assert_equals(cookies.length, 8);
assert_equals(cookies.length, 9);
let cookieMap = new Map();
for (const cookie of cookies) {
cookieMap.set(cookie["name"], cookie);
Expand Down Expand Up @@ -108,5 +109,15 @@
assert_equals(cookieMap.get("test7")["httpOnly"], false);
assert_equals(cookieMap.get("test7")["expiry"], undefined);
assert_equals(cookieMap.get("test7")["sameSite"], "Lax");

// test8 [Partitioned]
assert_equals(cookieMap.get("test8")["name"], "test8");
assert_equals(cookieMap.get("test8")["value"], "8");
assert_equals(cookieMap.get("test8")["path"], "/infrastructure/testdriver");
assert_equals(cookieMap.get("test8")["domain"], "{{host}}");
assert_equals(cookieMap.get("test8")["secure"], true);
assert_equals(cookieMap.get("test8")["httpOnly"], false);
assert_equals(cookieMap.get("test8")["expiry"], undefined);
assert_equals(cookieMap.get("test8")["sameSite"], "None");
}, "Get all HTTPS cookies");
</script>
13 changes: 13 additions & 0 deletions infrastructure/testdriver/get_named_cookie.sub.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
document.cookie = "test5=5; SameSite=Strict";
document.cookie = "test6=6; SameSite=None; Secure";
document.cookie = "test7=7; SameSite=Lax";
document.cookie = "test8=8; Secure; Partitioned; SameSite=None";

// test0
let cookie = await test_driver.get_named_cookie("test0");
Expand Down Expand Up @@ -110,5 +111,17 @@
assert_equals(cookie["httpOnly"], false);
assert_equals(cookie["expiry"], undefined);
assert_equals(cookie["sameSite"], "Lax");

// test8 [Partitioned]
cookie = await test_driver.get_named_cookie("test8");
assert_equals(cookie["name"], "test8");
assert_equals(cookie["value"], "8");
assert_equals(cookie["path"], "/infrastructure/testdriver");
assert_equals(cookie["domain"], "{{host}}");
assert_equals(cookie["secure"], true);
assert_equals(cookie["httpOnly"], false);
assert_equals(cookie["expiry"], undefined);
assert_equals(cookie["sameSite"], "None");

}, "Get Named HTTPS cookie");
</script>