Enabled ignore_common_filters on IS_IN_DB #642
Conversation
IS_NOT_IN_DB('...', ignore_common_filters=True) had already been implemented but IS_IN_DB had not.
Example:
db.auth_user.SelectedOrganisationID.requires = IS_EMPTY_OR(IS_IN_DB(db, 'Organisation.id', '%(LongName)s', multiple=False, zero=T(''), ignore_common_filters=True))
I really wanted to use this method of getting a Set but it does not seem to work: db(query, ignore_common_filters=True)
The IS_IN_DB validator was ignoring the ignore_common_filters option when it was added to the Set definition. It now checks if this has been specified. This improves the previous change which only checked if the ignore_common_filters option was specified in the IS_IN_DB function.
|
This should not be merged because it does this while building the set: |
mdipierro
force-pushed
the
master
branch
2 times, most recently
from
3b526f9 to
2a77f13
Compare
|
Based on leonel's comment above I will decline this |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #642 +/- ##
==========================================
- Coverage 70.33% 70.32% -0.01%
==========================================
Files 73 73
Lines 11581 11584 +3
Branches 2555 2556 +1
==========================================
+ Hits 8146 8147 +1
- Misses 2765 2766 +1
- Partials 670 671 +1 |
IS_NOT_IN_DB('...', ignore_common_filters=True) had already been implemented but IS_IN_DB had not.
Example:
db.auth_user.SelectedOrganisationID.requires = IS_IN_DB(db, 'Organisation.id', '%(LongName)s', ignore_common_filters=True)
Actually, I really wanted to use the Set method (db(query, ignore_common_filters=True)) in IS_IN_DB but it does not seem to work.