Enabled ignore_common_filters on IS_IN_DB #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IS_NOT_IN_DB('...', ignore_common_filters=True) had already been implemented but IS_IN_DB had not.
Example:
db.auth_user.SelectedOrganisationID.requires = IS_EMPTY_OR(IS_IN_DB(db, 'Organisation.id', '%(LongName)s', multiple=False, zero=T(''), ignore_common_filters=True))
I really wanted to use this method of getting a Set but it does not seem to work: db(query, ignore_common_filters=True)
The IS_IN_DB validator was ignoring the ignore_common_filters option when it was added to the Set definition. It now checks if this has been specified. This improves the previous change which only checked if the ignore_common_filters option was specified in the IS_IN_DB function.
|
This should not be merged because it does this while building the set: |
mdipierro
force-pushed
the
master
branch
2 times, most recently
from
3b526f9
to
2a77f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS_NOT_IN_DB('...', ignore_common_filters=True) had already been implemented but IS_IN_DB had not.
Example:
db.auth_user.SelectedOrganisationID.requires = IS_IN_DB(db, 'Organisation.id', '%(LongName)s', ignore_common_filters=True)
Actually, I really wanted to use the Set method (db(query, ignore_common_filters=True)) in IS_IN_DB but it does not seem to work.