Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled ignore_common_filters on IS_IN_DB #642

Closed
wants to merge 2 commits into from
Closed

Enabled ignore_common_filters on IS_IN_DB #642

wants to merge 2 commits into from

Commits on Oct 6, 2020

  1. Enabled ignore_common_filters on IS_IN_DB 

    IS_NOT_IN_DB('...',  ignore_common_filters=True) had already been implemented but IS_IN_DB had not.

Example:
db.auth_user.SelectedOrganisationID.requires = IS_EMPTY_OR(IS_IN_DB(db, 'Organisation.id', '%(LongName)s', multiple=False, zero=T(''), ignore_common_filters=True))

I really wanted to use this method of getting a Set but it does not seem to work: db(query, ignore_common_filters=True)
    @agrogers
    agrogers committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    43838a9 View commit details
    Browse the repository at this point in the history

  2. Enabled db(query, ignore_common_filters=True) for IS_IN_DB 

    The IS_IN_DB validator was ignoring the ignore_common_filters option when it was added to the Set definition. It now checks if this has been specified. This improves the previous change which only checked if the ignore_common_filters option was specified in the IS_IN_DB function.
    @agrogers
    agrogers committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    c792e58 View commit details
    Browse the repository at this point in the history