This repository has been archived by the owner on Dec 19, 2020. It is now read-only.
Smaller fixes and improvements #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix help string (ret_stack_size)
File type discovery is sometimes based on the extension. It is probably good practise to have SystemVerilog files with the .sv extension.
Currently the types are defined flatly in a definition file, which needs to be compiled in the compilation unit before the majority of the modules. The much cleaner way is to do that in a package and include it at the proper place so that both ports and the module itself know the types.
wallento
force-pushed
the
master
branch
2 times, most recently
from
46f61f5 to
091e09b
Compare
|
Moved the whitespace fix to #4 |
|
Thank you for your feedback and proposed changes Stefan. Because your PR affects RTL files, the changes will first have to pass through our review and qualification process. This may take a while. Please be patient. Thanks, |
|
We accept all of these changes. We will release these shortly as part of the Swerv 1.1 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds some smaller fixes primarily to improve compatibility.
Cheers,
Stefan