Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interaction between pane swapping / rotating and client domains. #5009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogdan2412
Copy link
Contributor

This should address #4200.

Currently pane swapping and rotation only works correctly on local domains since none of the state is propagated to the remote mux server.

This patch adds a couple of RPCs for rotating panes and for swapping an active pane with the pane at a given index. Additionally, it renames the corresponding methods on the mux::tab module, prefixing them with local_, adds remote_ versions of them to Domains and adds a convenience method on mux, mirroring the pattern used for move_pane_to_new_tab, which dispatches to the relevant method.

This incidentally fixes a typo in the Lua API which was previously always rotating panes in a single direction.

This should address wez#4200.

Currently pane swapping and rotation only works correctly on local
domains since none of the state is propagated to the remote mux server.

This patch adds a couple of RPCs for rotating panes and for swapping
an active pane with the pane at a given index. Additionally, it renames
the corresponding methods on the `mux::tab` module, prefixing them with
`local_`, adds `remote_` versions of them to Domains and adds a
convenience method on `mux`, mirroring the pattern used for
`move_pane_to_new_tab`, which dispatches to the relevant method.

This incidentally fixes a typo in the Lua API which was previously
always rotating panes in a single direction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant