Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Fixes to installing as shared #100

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes to installing as shared #100

wants to merge 4 commits into from

Conversation

bwrsandman
Copy link
Contributor

@bwrsandman bwrsandman commented Jan 31, 2021 •
edited
Loading

  • cmake: turn on CMAKE_POSITION_INDEPENDENT_CODE for shared
    • This prevents an error while linking static libs into shared libs on linux
  • install bx and bimg as shared libs if building as shared
  • don't install static libs if shared libs have been built

@bwrsandman
cmake: turn on CMAKE_POSITION_INDEPENDENT_CODE for shared
db7e9cb 
This prevents an error while linking libbx.a into libbgfx.so on linux
@bwrsandman bwrsandman changed the title cmake: turn on CMAKE_POSITION_INDEPENDENT_CODE for shared Fixes to installing as shared Jan 31, 2021
@bwrsandman bwrsandman mentioned this pull request Jan 31, 2021
Open
@bwrsandman bwrsandman mentioned this pull request Apr 29, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bwrsandman