[WEJBHTTP-142] First round of refactorings in EJB part - focus on client side of the protocol #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejb/src/main/java/org/wildfly/httpclient/ejb/RequestBuilder.java
Outdated
Show resolved
Hide resolved
ejb/src/main/java/org/wildfly/httpclient/ejb/RequestBuilder.java
Outdated
Show resolved
Hide resolved
| import org.wildfly.httpclient.common.Protocol; | ||
|
|
||
| import java.lang.reflect.Method; | ||
|
|
There was a problem hiding this comment.
Description of class and its purpose? Sample usage example would be nice as well, as certain methods need to be invoked before others (e.g. setting the request type).
fl4via
requested changes
Jul 24, 2024
ejb/src/main/java/org/wildfly/httpclient/ejb/HttpEJBInvocationBuilder.java
Outdated
Show resolved
Hide resolved
ejb/src/main/java/org/wildfly/httpclient/ejb/HttpEJBInvocationBuilder.java
Outdated
Show resolved
Hide resolved
… distinctName & beanName method parameters. These values are available as instance fields.
…request method, second set HTTP request path and finally set HTTP request headers.
…ry to call UTF-8.name() method which may throw UnsupportedEncodingException.
…ring() conversion method. StringBuilder supports appending of booleans directly.
…ds parameter. We can distinguish proper HTTP request prefix path via HttpEJBInvocationBuilder method signatures.
…troducing appendPath(StringBuilder,String) utility method.
…emoving useless 'public' method modifier.
… getters. Making all its method arguments final.
…dPath() into appendPath() & appendEncodedPath() methods. Adjusting code accordingly.
…anPath() & buildModulePath() into buildBeanPath() method.
…, distinctName & beanName method parameters. These are available as instance fields.
…ath() and appendEncoedPath() utility methods.
…ath() & appendedEncodedPath() methods.
…d, invocationId & cancelIfRunning method parameters. These are available as instance fields.
…BeanRequestPath() method.
…BeanRequestMethod() method.
…eanPath() method to appendBeanPath() and changing its parameters order.
…RequestHeaders() method.
…eanRequestMethod() to setRequestMethod().
…eanRequestPath() to setRequestPath().
…cation type is not handled properly.
…variable in HttpEJBReceiver.
…tionType enum values.
…eName, distinctName & beanName strings in HttpEJBInvocationBuilder.
…ppendOperationPath() method.
…uilder's appendOperationPath() method call one method up in the caller's stack.
…JBInvocationBuilder class for configuring client requests.
…s parameter 'mountPoint' to 'prefix'.
…nRequestPath() methods.
…e' field to 'requestType'.
…r in RequestType enum.
…in RequestType enum.
…over default one.
…rom HttpEJBReceiver to RequestBuilder.
ropalka
force-pushed
the
WEJBHTTP-142_round1
branch
from
8ef967e to
b70a8f8
Compare
|
Typo 'usealess' was fixed in PR refresh Flavia. |
|
@fl4via @rachmatowicz please review again. |
ropalka
force-pushed
the
WEJBHTTP-142_round1
branch
from
b70a8f8 to
c522932
Compare
fl4via
approved these changes
Sep 25, 2024
| @@ -283,7 +283,7 @@ protected SessionID createSession(final EJBReceiverSessionCreationContext receiv | |||
| CompletableFuture<SessionID> result = new CompletableFuture<>(); | |||
|
|
|||
| RequestBuilder builder = new RequestBuilder() | |||
| .setRequestType(RequestType.CREATE_SESSION) | |||
| .setRequestType(RequestType.OPEN) | |||
There was a problem hiding this comment.
Because there is no open operation in the EJB spec, I am not very fond of this renaming. CREATE_SESSION implies that we are creating the session, which is what we actually are doing here. OPEN is confusing. We use open to refer to transactions, resources, connections, but to me it does not relate to the create session operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WEJBHTTP-142