[WEJBHTTP-142] First round of refactorings in EJB part - focus on client side of the protocol#219

Merged

fl4via merged 49 commits intowildfly:mainfrom ropalka:WEJBHTTP-142_round1

Sep 25, 2024

+346-343

Commits on Aug 13, 2024

[WEJBHTTP-142] Refactoring - Eliminating useless appName, moduleName, distinctName & beanName method parameters. These values are available as instance fields.
ropalka
committed
[WEJBHTTP-142] Refactoring - Reordering method calls. First set HTTP request method, second set HTTP request path and finally set HTTP request headers.
ropalka
committed
[WEJBHTTP-142] Refactoring - Removing useless code. It is not necessary to call UTF-8.name() method which may throw UnsupportedEncodingException.
ropalka
committed
[WEJBHTTP-142] Refactoring - It is not necessary to call Boolean.toString() conversion method. StringBuilder supports appending of booleans directly.
ropalka
committed
[WEJBHTTP-142] Refactoring - It is not necessary to pass 'type' methods parameter. We can distinguish proper HTTP request prefix path via HttpEJBInvocationBuilder method signatures.
ropalka
committed
[WEJBHTTP-142] Refactoring - Optimizing StringBuilder appends plus introducing appendPath(StringBuilder,String) utility method.
ropalka
committed
[WEJBHTTP-142] Refactoring - Reordering methods and enum definition.
ropalka
committed
[WEJBHTTP-142] Refactoring - Making HttpEJBInvocationBuilder final. Removing useless 'public' method modifier.
ropalka
committed
[WEJBHTTP-142] Refactoring - Removing HttpEJBInvocationBuilder unused getters. Making all its method arguments final.
ropalka
committed
[WEJBHTTP-142] Refactoring - Splitting HttpEJBInvocationBuilder.appendPath() into appendPath() & appendEncodedPath() methods. Adjusting code accordingly.
ropalka
committed
[WEJBHTTP-142] Refactoring - Merging HttpEJBInvocationBuilder buildBeanPath() & buildModulePath() into buildBeanPath() method.
ropalka
committed
[WEJBHTTP-142] Refactoring - Removing unnecessary appName, moduleName, distinctName & beanName method parameters. These are available as instance fields.
ropalka
committed
[WEJBHTTP-142] Removing useless HttpEJBInvocationBuilder method javadoc comments.
ropalka
committed
[WEJBHTTP-142] Making HttpEJBInvocationBuilder method parameters final.
ropalka
committed
[WEJBHTTP-142] Refactoring - Reuse HttpEJBInvocationBuilder's appendPath() and appendEncoedPath() utility methods.
ropalka
committed
[WEJBHTTP-142] Refactoring - Merging HttpEJBInvocationBuilder appendPath() & appendedEncodedPath() methods.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming three HttpEJBInvocationBuilder methods.
ropalka
committed
[WEJBHTTP-142] Refactoring - Removing unnecessary beanId, view, method, invocationId & cancelIfRunning method parameters. These are available as instance fields.
ropalka
committed
[WEJBHTTP-142] Refactoring - Introducing HttpEJBInvocationBuilder.getBeanRequestPath() method.
ropalka
committed
[WEJBHTTP-142] Refactoring - Introducing HttpEJBInvocationBuilder.getBeanRequestMethod() method.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming HttpEJBInvocationBuilder buildBeanPath() method to appendBeanPath() and changing its parameters order.
ropalka
committed
[WEJBHTTP-142] Refactoring - Reaordering static import statements.
ropalka
committed
[WEJBHTTP-142] Refactoring - Introducing HttpEJBInvocationBuilder.setRequestHeaders() method.
ropalka
committed
[WEJBHTTP-142] Refactoring - Use more static imports in HttpEJBInvocationBuilder.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming HttpEJBInvocationBuilder's getBeanRequestMethod() to setRequestMethod().
ropalka
committed
[WEJBHTTP-142] Refactoring - Move HttpEJBInvocationBuilder's setRequestHeaders() method to other line.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming HttpEJBInvocationBuilder's getBeanRequestPath() to setRequestPath().
ropalka
committed
[WEJBHTTP-142] Removing TODO comments plus adding author.
ropalka
committed
[WEJBHTTP-142] Prevent future issues if HttpEJBInvocationBuilder invocation type is not handled properly.
ropalka
committed
[WEJBHTTP-142] Refactoring - Introducing ClientRequest request local variable in HttpEJBReceiver.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming HttpEJBInvocationBuilder.InvocationType enum values.
ropalka
committed
[WEJBHTTP-142] Refactoring - Use EJBLocator instead of appName, moduleName, distinctName & beanName strings in HttpEJBInvocationBuilder.
ropalka
committed
[WEJBHTTP-142] Refactoring - Introducing HttpEJBInvocationBuilder's appendOperationPath() method.
ropalka
committed
[WEJBHTTP-142] Refactoring - Move newly introduced HttpEJBInvocationBuilder's appendOperationPath() method call one method up in the caller's stack.
ropalka
committed
[WEJBHTTP-142] Refactoring - Let HttpEJBDiscoveryProvider reuse HttpEJBInvocationBuilder class for configuring client requests.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming HttpEJBInvocationBuilder methods parameter 'mountPoint' to 'prefix'.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming HttpEJBInvocationBuilder's *BeanRequestPath() methods.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming HttpEJBInvocationBuilder to RequestBuilder.
ropalka
committed
[WEJBHTTP-142] Refactoring - Moving RequestBuilder.InvocationType to RequestType.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming RequestBuilder's 'invocationType' field to 'requestType'.
ropalka
committed
[WEJBHTTP-142] Refactoring - Introducing HTTP request method parameter in RequestType enum.
ropalka
committed
[WEJBHTTP-142] Refactoring - Introducing HTTP request path parameter in RequestType enum.
ropalka
committed
[WEJBHTTP-142] Refactoring - Renaming RequestType enum values.
ropalka
committed
[WEJBHTTP-142] Enhancement - Prefer targetContext's protocol version over default one.
ropalka
committed
[WEJBHTTP-142] Refactoring - Moving remaining headers configuration from HttpEJBReceiver to RequestBuilder.
ropalka
committed