[WPB-14307] domain verification (enterprise feature) #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes/initiative: scale
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
WPB-14307-domain-registration-endpoints
branch
2 times, most recently
from
d0e1ec2 to
4905d23
Compare
fisx
changed the title
pcapriotti
force-pushed
the
WPB-14307-domain-registration-endpoints
branch
from
bb2ba52 to
86ad89c
Compare
battermann
force-pushed
the
WPB-14307-domain-registration-endpoints
branch
from
28fed09 to
8a81893
Compare
pcapriotti
force-pushed
the
WPB-14307-domain-registration-endpoints
branch
from
635443b to
fb921f3
Compare
battermann
force-pushed
the
WPB-14307-domain-registration-endpoints
branch
from
cefadec to
1e55da6
Compare
pcapriotti
force-pushed
the
WPB-14307-domain-registration-endpoints
branch
from
16c3132 to
470f4c5
Compare
pcapriotti
force-pushed
the
WPB-14307-domain-registration-endpoints
branch
2 times, most recently
from
d5965da to
72607ca
Compare
pcapriotti
force-pushed
the
WPB-14307-domain-registration-endpoints
branch
from
8346682 to
ac2d09c
Compare
stefanwire
approved these changes
Jan 23, 2025
Comment on lines
18
to
+19
| import Data.OpenApi qualified as OpenApi | ||
| import Data.OpenApi qualified as S |
There was a problem hiding this comment.
nit: loading same module and making it available in two different namespaces.
| -- | interprets galley by statically returning the values passed | ||
| miniSparAPIAccess :: InterpreterFor SparAPIAccess r | ||
| miniSparAPIAccess = interpret $ \case | ||
| GetIdentityProviders _ -> error "GetIdentityProviders not implemented in miniSparAPIAccess" |
There was a problem hiding this comment.
Suggested change
| GetIdentityProviders _ -> error "GetIdentityProviders not implemented in miniSparAPIAccess" | |
| GetIdentityProviders _ -> error "GetIdentityProviders not implemented in miniSparAPIAccess" |
| @@ -1501,6 +1517,50 @@ getSystemSettingsInternal _ = do | |||
| let iSettings = SystemSettingsInternal $ fromMaybe False optSettings.enableMLS | |||
| pure $ SystemSettings pSettings iSettings | |||
|
|
|||
| requestDomainVerificationToken :: | |||
| forall r. | |||
| (_) => | |||
There was a problem hiding this comment.
Is this a constraint? And why is this needed? 🤔
battermann
pushed a commit
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this only refers to the submodule's feature branch.
Ticket: https://wearezeta.atlassian.net/browse/WPB-14307
Checklist
changelog.d