Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Vite links to use their new domain #12117

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

ArmandPhilippot
Copy link
Contributor

Changes

Vite has a new domain so we are updating all documentation files to use this new domain (vitejs.dev > vite.dev). So I updated:

  • error-data.ts to update auto-generated errors files
  • @types/astro.ts to update the Configuration reference page

I haven't touch other files. But if needed I can update the Vite links in other files as well (mostly CHANGELOGs, a README file and client.d.ts).

Testing

N/A (well, I checked that the links are still working)

Docs

This helps closing an issue opened by Sarah in withastro/docs: withastro/docs#9548
I don't think we need a changeset for that (unless they are used to determine when to update the doc?)
/cc @withastro/maintainers-docs

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: 756ea07

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Princesseuh
Copy link
Member

Updating the other links would be appreciated, if you have the time!

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Oct 3, 2024
@ArmandPhilippot
Copy link
Contributor Author

@Princesseuh Done! 😉

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Princesseuh Princesseuh merged commit a46839a into withastro:main Oct 3, 2024
5 checks passed
@ArmandPhilippot ArmandPhilippot deleted the docs/update-vite-links branch October 3, 2024 21:30
@astrobot-houston astrobot-houston mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants