Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(de): fix typos in the German translations #2914

Merged
merged 12 commits into from
Feb 25, 2025

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Feb 24, 2025

Description

  • I reread the Starlight documentation in German and found some translation mistakes, which will be fixed with this PR:
    • translation mistakes (word has wrong meaning)
    • add ­ to all long words (not in code blocks and ignoring Internationalisierung; title and description frontmatter questionable changes)
    • removal of space between number and procent symbol (questionable change, discussion needed: https://de.wikipedia.org/wiki/Prozentzeichen)

May I ask that a native speaker should review this PR because there are some questions no translation tool will be able to answer? Maybe Chris, or I will ask some other German translator from Discord

Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: 7ea0cba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 24, 2025
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 7ea0cba
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67bdd0cd197668000851ac0b
😎 Deploy Preview https://deploy-preview-2914--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Feb 24, 2025

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: typo.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

Locale File Note
de components/icons.mdx Localization changed, will be marked as complete.
de components/link-cards.mdx Localization changed, will be marked as complete.
de components/tabs.mdx Localization changed, will be marked as complete.
de components/using-components.mdx Localization changed, will be marked as complete.
de environmental-impact.md Localization changed, will be marked as complete.
de getting-started.mdx Localization changed, will be marked as complete.
de guides/authoring-content.mdx Localization changed, will be marked as complete.
de guides/css-and-tailwind.mdx Localization changed, will be marked as complete. 🔄️
de guides/customization.mdx Localization changed, will be marked as complete.
de guides/i18n.mdx Localization changed, will be marked as complete.
de guides/overriding-components.mdx Localization changed, will be marked as complete.
de guides/pages.mdx Localization changed, will be marked as complete.
de guides/route-data.mdx Localization changed, will be marked as complete.
de guides/sidebar.mdx Localization changed, will be marked as complete.
de guides/site-search.mdx Localization changed, will be marked as complete.
de index.mdx Localization changed, will be marked as complete.
de manual-setup.mdx Localization changed, will be marked as complete.
de reference/configuration.mdx Localization changed, will be marked as complete.
de reference/frontmatter.md Localization changed, will be marked as complete.
de reference/overrides.md Localization changed, will be marked as complete.
de reference/plugins.md Localization changed, will be marked as complete.
de reference/route-data.mdx Localization changed, will be marked as complete.
de resources/community-content.mdx Localization changed, will be marked as complete.
de resources/plugins.mdx Localization changed, will be marked as complete. 🔄️
de resources/showcase.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor Author

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fragwürdige Übersetzungen von "docs"

@trueberryless trueberryless marked this pull request as ready for review February 24, 2025 16:57
Copy link

@gamersi gamersi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trueberryless! Overall seems like quite a few improvements 🙌

Left a couple of questions.

@trueberryless
Copy link
Contributor Author

Thanks for all the AWESOME reviews. Love it! ❤️ Should be good to go now I think.

@delucis delucis changed the title i18n(de): fix some generic translation mistakes in the German language i18n(de): fix typos in the German translations Feb 25, 2025
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trueberryless!

@delucis delucis merged commit bd63b26 into withastro:main Feb 25, 2025
15 checks passed
@trueberryless trueberryless deleted the de-fixes branch February 25, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants