-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Pay ECE: add payment flow using confirmation tokens #3741
Amazon Pay ECE: add payment flow using confirmation tokens #3741
Conversation
d5d7c44
to
6588548
Compare
9612d93
to
35cf126
Compare
// TODO: Uncomment me to test Google Pay on confirmation token flow. | ||
// Remove me before merging to production. | ||
// if ( [ 'googlePay', 'google_pay' ].includes( expressPaymentType ) ) { | ||
// return false; | ||
// } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👆 Uncomment this section to test the confirmation token flow, using Google Pay.
b3df848
to
af462fc
Compare
e6865c0
to
574c853
Compare
c8a6961
to
a47d535
Compare
b3306c3
to
a970393
Compare
👋 hi! It looks like changelog.txt and readme.txt needs to be updated |
includes/payment-methods/class-wc-stripe-upe-payment-gateway.php
Outdated
Show resolved
Hide resolved
I think it is OK for this PR, but we might want to create a new issue to handle this later. Some merchants do complain about these kind of changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, Anne! Code is nice and it mostly works as intended:
- Purchase items using ECE on the different pages that we display them: product page, classic/block checkout, classic/block cart, and Pay-for-Order page. Purchases should behave as expected.
- Purchase products using non-express payment methods, e.g. credit card, Klarna. Purchases should behave as expected.
- With Google Pay set to use confirmation tokens, purchase items using Google Pay on the different pages where we display them.
❌ I get this on any page after removing that comment
- In wp-admin, check that the orders get set to "Processing" or "Completed". With confirmation tokens, you may have to wait a few minutes (around 3-5 mins) for it.
❌ Not possible to test due the previous error
- Test confirmation token flow + manual capture:
- Verify that you can purchase items without any problem.
- Change the status to "Processing" to capture the payment.
❌ Not possible to test due the previous error
Oof 😓, sorry about that. I added a last-minute tweak in 817749a to support manual captures and ended up breaking automatic capture. Fixed in f124d78, and tested for both scenarios! |
Works now! Thanks for fixing the issue 👍 |
Fixes #3737
Changes proposed in this Pull Request:
To set the stage for Amazon Pay, we need to introduce a payment flow that uses confirmation tokens instead of manually created payment methods.
Since Amazon Pay does not support
paymentMethodCreation: manual
, we cannot use the same payment element to create all express checkout buttons.This PR makes the following changes:
Testing instructions
changelog.txt
andreadme.txt
(or does not apply)Post merge