-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async methods and error stack traces, to reduce crashing and help debugging #67
Open
Erhannis
wants to merge
27
commits into
woodemi:master
Choose a base branch
from
Erhannis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid, so you can tell where the errors are happening.
Oh - it should perhaps be noted that I only added the stack traces to the invokeMethod errors in QuickBlue for Android. |
Appreciate the merge of my fork. However, please note that the serviceUUID-Filter is not implemented for Linux. Credits for the fix of some crashes under windows: https://github.com/Yongle-Fu/flutter_blue_plus |
…y were needed, so I removed the sdk limits and now it works.
…to NeariX67-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in woodemi/quick_blue#126 :
As it was, any of several different mistakes (such as not discovering services before trying to read a characteristic) would cause a PlatformException to be thrown in an unawaited Future, crashing the whole app. I've converted all such methods as I've found from void to async Future, enabling the user to await their completion or add a catchError. I also added a stack trace to a number of otherwise more opaque errors.
I split the async and trace changes into two commits, this time.
Also - I noticed a number of other places where async methods are called without either awaiting them nor handling errors. "If the future completes with an error, it was likely a mistake to not await it. That error will still occur and will be considered unhandled...." ( https://api.dart.dev/stable/2.15.1/dart-async/unawaited.html ) I wasn't sure in these cases whether the correct behavior was to await, or add an error handler, so I marked the ones I saw with a TODO comment. I didn't really search for them, though, so I expect there are still other examples.