Async methods and error stack traces, to reduce crashing and help debugging #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're moving to https://github.com/woodemi/quick.flutter This repo would be deprecated |
|
Ok; I remade the changes in the new repo: woodemi/quick.flutter#67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was, any of several different mistakes (such as not discovering services before trying to read a characteristic) would cause a PlatformException to be thrown in an unawaited Future, crashing the whole app. I've converted all such methods as I've found from
voidto asyncFuture<void>, enabling the user to await their completion or add acatchError. I also added a stack trace to a number of otherwise more opaque errors.