-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CategoryTemplateService 테스트 #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고했어요 짱수 간단한 코멘트 남겨뒀어요 ~
backend/src/test/java/codezap/category/service/CategoryTemplateServiceTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 짱수~!
수고하셨습니다 🔥
코멘트 남겼으니 확인 부탁드립니당
@@ -52,7 +55,7 @@ void deleteCategoryFailWithUnauthorized() { | |||
|
|||
@Test | |||
@DisplayName("카테고리 삭제 실패: 이미 없는 카테고리") | |||
void deleteCategoryFailWithNotExistCateory() { | |||
void deleteCategoryFailWithNotExistCategory() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nested
로 변경해주는 건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
짱수가 작성한 코드는 아니지만 테스트 코드의 질을 높이기 위한 작업중이니까 의견 남기겠습니다!!
categoryService.deleteById
에 대한 테스트인데 해당 테스트 코드는 deleteById
가 정상적으로 동작한다는 가정하에 작성된 코드 같아요.
이미 없는 카테고리를 삭제하는 테스트보다는 애초에 없는 ID에 대한 삭제 테스트를 하는 건 어떤가요?
이전까지의 테스트 코드에서 했던 것처럼 notSavedId
등을 활용해서요!
backend/src/test/java/codezap/category/service/CategoryTemplateServiceTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 짱수!!
메소드가 별로 없어서 간단하고 좋네요ㅎㅎ
@@ -52,7 +55,7 @@ void deleteCategoryFailWithUnauthorized() { | |||
|
|||
@Test | |||
@DisplayName("카테고리 삭제 실패: 이미 없는 카테고리") | |||
void deleteCategoryFailWithNotExistCateory() { | |||
void deleteCategoryFailWithNotExistCategory() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
짱수가 작성한 코드는 아니지만 테스트 코드의 질을 높이기 위한 작업중이니까 의견 남기겠습니다!!
categoryService.deleteById
에 대한 테스트인데 해당 테스트 코드는 deleteById
가 정상적으로 동작한다는 가정하에 작성된 코드 같아요.
이미 없는 카테고리를 삭제하는 테스트보다는 애초에 없는 ID에 대한 삭제 테스트를 하는 건 어떤가요?
이전까지의 테스트 코드에서 했던 것처럼 notSavedId
등을 활용해서요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
짱수최고 👍
간단한 제안 남겼습니다.
backend/src/test/java/codezap/category/service/CategoryTemplateServiceTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
장수 수고했어요
기념으로 장수 합시다 깔깔 최고 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿!! 고생하셨습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
짱 수 굿 ~!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많았어요 짱수!
⚡️ 관련 이슈
close #645
📍주요 변경 사항
🎸기타
CategoryTemplateService
의 존재에 대해 이야기를 해 보면 좋을 것 같아요.