Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CategoryTemplateService 테스트 #658
CategoryTemplateService 테스트 #658
Changes from 3 commits
711e6e7
f427dd8
17cbcd9
1fe849e
96c6b42
8c47641
b4c5eca
deb02b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nested
로 변경해주는 건 어떨까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
짱수가 작성한 코드는 아니지만 테스트 코드의 질을 높이기 위한 작업중이니까 의견 남기겠습니다!!
categoryService.deleteById
에 대한 테스트인데 해당 테스트 코드는deleteById
가 정상적으로 동작한다는 가정하에 작성된 코드 같아요.이미 없는 카테고리를 삭제하는 테스트보다는 애초에 없는 ID에 대한 삭제 테스트를 하는 건 어떤가요?
이전까지의 테스트 코드에서 했던 것처럼
notSavedId
등을 활용해서요!