Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] fix : 리뷰 작성 페이지에서 유효하지 않은 답변 오류 수정 #333

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

BadaHertz52
Copy link
Contributor


🚀 어떤 기능을 구현했나요 ?

  • 리뷰 작성 페이지에서 유효하지 않은 답변의 값을 수정했어요
  • 서술형 : 빈문자열
  • 객관식: 빈 배열

🔥 어떻게 해결했나요 ?

  • 빠르게

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 코드한번 봐주세요.

📚 참고 자료, 할 말

  • 오류 고쳐져라

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

긴급 PR!!!

Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존의 null 방식보다 빈 값이라는 걸 의도적으로 안전하게 드러낼 수 있는 것 같아 좋아요!

Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요! 선택 질문 정책은 다시 이야기 나누어봐요🔥

@BadaHertz52 BadaHertz52 merged commit c1eeb74 into develop Aug 13, 2024
5 checks passed
@donghoony donghoony deleted the fe/fix/332_review_writing_error branch August 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] 서술형에서 입력이 없을 경우의 오류 수정
4 participants