Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] fix : 리뷰 작성 페이지에서 유효하지 않은 답변 오류 수정 #333

Merged
merged 7 commits into from
Aug 13, 2024
Merged

[FE] fix : 리뷰 작성 페이지에서 유효하지 않은 답변 오류 수정 #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39ab5fe
fix: 리뷰 작성 페이지에서 api 가 아닌 목 데이터를 받아오고 있는 것 수정
BadaHertz52 Aug 12, 2024
bf5ce48
fix: 리뷰 작성 페이지에서 제출 실패 시에도 navigate 작동하는 오류 수정
BadaHertz52 Aug 12, 2024
6ca9a82
Update index.tsx
BadaHertz52 Aug 12, 2024
8bc8c32
chore: ReviewWriting 폴더 삭제
BadaHertz52 Aug 12, 2024
30b286d
Merge branch 'develop' of https://github.com/woowacourse-teams/2024-r…
BadaHertz52 Aug 12, 2024
824f47e
Merge branch 'develop' of https://github.com/woowacourse-teams/2024-r…
BadaHertz52 Aug 13, 2024
54ce3a7
fix: 유효하지 않은 답변들을 빈문자열, 빈배열로 수정
BadaHertz52 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/hooks/review/writingCardForm/useMultipleChoice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const useMultipleChoice = ({ question, updateAnswerMap }: UseMultipleChoiceProps
// 유효한 선택(=객관식 문항의 최소,최대 개수를 지켰을 경우)인지에 따라 answer 변경
updateAnswerMap({
questionId: question.questionId,
selectedOptionIds: isValidatedChoice(newSelectedOptionList) ? newSelectedOptionList : null,
selectedOptionIds: isValidatedChoice(newSelectedOptionList) ? newSelectedOptionList : [],
text: null,
});
};
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/hooks/review/writingCardForm/useTextAnswer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const useTextAnswer = ({ question, updateAnswerMap }: UseTextAnswerProps) => {
setTextAnswer(value);
}
// 유효한 답변인지 여부에 따라 답변 변경
updateAnswerMap({ questionId: question.questionId, selectedOptionIds: null, text: isValidatedText ? value : null });
updateAnswerMap({ questionId: question.questionId, selectedOptionIds: null, text: isValidatedText ? value : '' });
};

return {
Expand Down