[FE] refactor: 리뷰 그룹 생성 API 요청 함수 및 MSW 핸들러, 테스트 추가 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadaHertz52
reviewed
Aug 19, 2024
|
|
||
| import QueryClientWrapper from '@/queryTestSetup/QueryClientWrapper'; | ||
|
|
||
| import { CREATED_REVIEW_REQUEST_CODE } from '../../../mocks/mockData/group'; |
There was a problem hiding this comment.
경로에 절대 경로 사용하면 어떨까요?
Suggested change
| import { CREATED_REVIEW_REQUEST_CODE } from '../../../mocks/mockData/group'; | |
| import { CREATED_REVIEW_REQUEST_CODE } from '@/mocks/mockData/group'; |
BadaHertz52
reviewed
Aug 19, 2024
| describe('usePostDataForReviewRequestCode', () => { | ||
| it('ReviewRequestCode를 발급받을 수 있다.', async () => { | ||
| // given | ||
| const dataForReviewRequestCode = { |
There was a problem hiding this comment.
Suggested change
| const dataForReviewRequestCode = { | |
| const DATA_FOR_REVIEW_REQUEST_CODE= { |
상수로 바꿔도 좋을 것 같아요.
There was a problem hiding this comment.
이 변수는 해당 테스트에서만 사용돼서 일단 별도로 상수화하지는 않았습니다!
…eview-me into fe/feat/413-new-create-review-group-api
soosoo22
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
HomePage에서 이름, 프로젝트 이름, 비밀번호를 입력했을 때ReviewDashboard로 접근할 수 있는 URL을 얻기 위한 API 호출 함수와 관련된 작업을 했습니다.🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료, 할 말
groupAccessCode로 통일하자고 했는데, 예전에 컴포넌트를 만들 때 이미password라는 이름을 너무 많이 사용하고 있어서 컴포넌트상의password는 별도로 수정하지 않고 API 요청을 보낼 때만groupAccessCode로 명시해서 보내고 있습니다.