-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] refactor: 리뷰 그룹 생성 API 요청 함수 및 MSW 핸들러, 테스트 추가 #420
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2db77bb
refactor: 새로운 URL 요청 함수 및 엔드포인트 작성
ImxYJL 49331ca
feat: reviewDashboard에 대한 경로 상수 추가
ImxYJL 40a1d06
refactor: URL 확인 모달 이름 변경
ImxYJL e719e26
refactor: 새 URL 생성 API 호출 함수를 리액트 쿼리에 적용
ImxYJL 1b2a8f9
chore: 리액트 쿼리 코드 변경으로 인해 deprecated된 테스트 코드 주석 처리
ImxYJL 5fbfcc9
refactor: 새로운 리뷰 URL 생성 API를 위한 모킹 핸들러 및 데이터 추가
ImxYJL 192fde4
test: usePostDataForReviewRequestCode의 정상 동작 테스트 작성
ImxYJL 1138a26
Merge branch 'develop' of https://github.com/woowacourse-teams/2024-r…
ImxYJL 1427328
chore: 불필요한 주석 삭제
ImxYJL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
// TODO: ROUTES -> ROUTE 및 상수 인덱스에 추가하기 | ||
export const ROUTES = { | ||
home: '/', | ||
reviewList: 'user/review-list', | ||
reviewWriting: 'user/review-writing', | ||
reviewWritingComplete: 'user/review-writing-complete', | ||
detailedReview: 'user/detailed-review', | ||
reviewDashboard: 'user/reviewDashboard', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
frontend/src/pages/HomePage/queries/usePostDataForReviewRequestCode.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,30 @@ | ||||||
import { renderHook, act, waitFor } from '@testing-library/react'; | ||||||
|
||||||
import QueryClientWrapper from '@/queryTestSetup/QueryClientWrapper'; | ||||||
|
||||||
import { CREATED_REVIEW_REQUEST_CODE } from '../../../mocks/mockData/group'; | ||||||
|
||||||
import usePostDataForReviewRequestCode from './usePostDataForReviewRequestCode'; | ||||||
|
||||||
describe('usePostDataForReviewRequestCode', () => { | ||||||
it('ReviewRequestCode를 발급받을 수 있다.', async () => { | ||||||
// given | ||||||
const dataForReviewRequestCode = { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
상수로 바꿔도 좋을 것 같아요. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 변수는 해당 테스트에서만 사용돼서 일단 별도로 상수화하지는 않았습니다! |
||||||
revieweeName: 'ollie', | ||||||
projectName: 'review-me', | ||||||
groupAccessCode: '1234', | ||||||
}; | ||||||
|
||||||
const { result } = renderHook(() => usePostDataForReviewRequestCode(), { wrapper: QueryClientWrapper }); | ||||||
|
||||||
// when | ||||||
act(() => { | ||||||
result.current.mutate(dataForReviewRequestCode); | ||||||
}); | ||||||
|
||||||
await waitFor(() => expect(result.current.isSuccess).toBe(true)); | ||||||
|
||||||
// then | ||||||
expect(result.current.data).toEqual(CREATED_REVIEW_REQUEST_CODE); | ||||||
}); | ||||||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 0 additions & 28 deletions
28
frontend/src/pages/HomePage/queries/usePostDataForURL.test.tsx
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
경로에 절대 경로 사용하면 어떨까요?