Add non-expanded ACL reporting for collections #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjsanger
force-pushed
the
feature/non-expanded-collection-acl
branch
from
e51277b to
a5cf497
Compare
To date baton reported non-expanded ACLs for data objects only (expansion meaning an access control for a group reporting all group members in addition to the group itself). This was because baton avoided using specific queries in case the required query was not installed. This change achieves non-expanded ACLs for collections in the same way that the native "ils" icommand does; by using a specific query that is supplied with iRODS and therefore wil be present unless removed by an administrator.
kjsanger
force-pushed
the
feature/non-expanded-collection-acl
branch
from
a5cf497 to
b2f4757
Compare
kjsanger
force-pushed
the
feature/non-expanded-collection-acl
branch
from
b1bbe9d to
09156b1
Compare
This iRODS function leaks memory, but by calling a lower level iRODS API function instead, we can avoid the problem malloc.
kjsanger
force-pushed
the
feature/non-expanded-collection-acl
branch
from
09156b1 to
7121fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To date baton reported non-expanded ACLs for data objects only (expansion meaning an access control for a group reporting all group members in addition to the group itself). This was because baton avoided using specific queries in case the required query was not installed.
This change achieves non-expanded ACLs for collections in the same way that the native "ils" icommand does; by using a specific query that is supplied with iRODS and therefore wil be present unless removed by an administrator.
This change also adds sorting of keys in JSON output by baton, to allow easier diff comparison.