Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcoming tab #186

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Upcoming tab #186

merged 2 commits into from
Oct 3, 2023

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Sep 26, 2023

Built on top of #185

@mgcam mgcam requested a review from nerdstrike September 26, 2023 14:25
@nerdstrike
Copy link
Collaborator

Hmm, TRACTION-RUN-752 B1 (dev DBs) is appearing in Upcoming, despite having well and run Complete, e.g. /ui/wells?activeTab=upcoming&page=1&idProduct=e7e3aaf1bd28268e895eece565047fe438f9059c9cd15c26d1368155e3b3c27e

@mgcam
Copy link
Member Author

mgcam commented Oct 2, 2023 •
edited
Loading

Hmm, TRACTION-RUN-752 B1 (dev DBs) is appearing in Upcoming, despite having well and run Complete, e.g. /ui/wells?activeTab=upcoming&page=1&idProduct=e7e3aaf1bd28268e895eece565047fe438f9059c9cd15c26d1368155e3b3c27e

This well did not produce any data, so it is not in incoming. It has not been QC-ed, it's not aborted, terminated, etc. So it is still upcoming and will eventually, after 12 weeks, disappear from that tab.

nerdstrike
nerdstrike approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, seems to work, found some dodgy data. What's not to like?

@nerdstrike nerdstrike merged commit bcc69fd into wtsi-npg:devel Oct 3, 2023
4 checks passed
@mgcam mgcam deleted the upcoming_tab branch June 7, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdstrike nerdstrike nerdstrike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgcam @nerdstrike