Removed QC-ed wells from the results for the 'Unknown' tab #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last release that works for us. 2.5.0 and 2.5.1 breaks out tests.
Added a new method, qc_state_for_products_exists, to perform a check for QC states for a list of product ids as a single query. Used this new method in a calculation for the upcoming tab instead of multiple calls to a similar methods for a single prodict id.
The QC team is dealing with 'problem' wells in this tab.
nerdstrike
requested changes
Jan 23, 2024
qc_state_for_products_exists -> products_have_qc_state qc_state_for_product_exists -> product_has_qc_state as suggested in the review.
nerdstrike
approved these changes
Jan 24, 2024
nerdstrike
requested changes
Jan 24, 2024
nerdstrike
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.