Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PacBioProductMetrics definition to include new per-product metrics #202

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

nerdstrike
Copy link
Collaborator

@nerdstrike nerdstrike requested a review from mgcam February 26, 2024 15:54
@nerdstrike nerdstrike force-pushed the extend_orm_product_metrics branch from d7b93f9 to 23ef830 Compare February 26, 2024 15:59
Copy link
Member

@mgcam mgcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from an error with the type for one of the columns.

mysqlINTEGER(unsigned=True), nullable=True, comment="The number of HiFi reads"
)
hifi_read_length_mean = Column(
mysqlSMALLINT(unsigned=True), nullable=True, comment="The mean HiFi read length"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hifi_read_length_mean is int

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@mgcam mgcam merged commit ad384c8 into wtsi-npg:devel Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants