try using in-built factory method #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdstrike
reviewed
Feb 29, 2024
| title="Run name", description="PacBio run name as registered in LIMS" | ||
| title="Run name", | ||
| description="PacBio run name as registered in LIMS", | ||
| validation_alias="pac_bio_run_name", |
lang_qc/models/pacbio/well.py
Outdated
| well_complete_time: datetime = Field(default=None, title="Well complete time") | ||
| run_status: str = Field(default=None, title="Current PacBio run status") | ||
| well_status: str = Field(default=None, title="Current PacBio well status") | ||
| run_start_time: Optional[datetime] = Field( |
There was a problem hiding this comment.
I think the emerging preference is now datetime | None rather than using Optional. Requires newer Python versions, but I think we're new enough already.
mgcam
force-pushed
the
use_builtin_factory
branch
2 times, most recently
from
fad25e9 to
3e49222
Compare
Simplified the code that uses this class and extends it. Optimised the use of methods that return QC state(s) for a product(s) according to the context.
mgcam
force-pushed
the
use_builtin_factory
branch
from
3e49222 to
249f031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.