Well libs #229
Merged
Well libs #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplemented the PacBioExperiment class, removed from_orm method, replaced it by a pre-init hook.
... for mlwh ORM classes so that common methods can be implemented. Customised __repr__ method for one of db classes.
nerdstrike
reviewed
Jun 12, 2024
lang_qc/db/mlwh_schema.py
Outdated
| A base class for declarative class definitions for the ml warehouse database. | ||
| """ | ||
|
|
||
| def get_row_description(self, fields: list[str]) -> str: |
There was a problem hiding this comment.
Maybe make this guy private?
| returned by the constructor. | ||
| """ | ||
|
|
||
| db_library: PacBioRun = Field(init_var=True) |
There was a problem hiding this comment.
Spot check - a "library" is the prep of one sample, therefore 1:1 with a row in pac_bio_run? As distinct from pool, which is a pool of libraries?
There was a problem hiding this comment.
Correct. A pool might contain one library as long as the library is indexed. The term pool is only used with indexed libraries.
Also made the helper function of the parent class 'private'.
nerdstrike
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.