Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update manifest4study file discrimination regex #187

Merged
merged 2 commits into from
Jun 28, 2021
Merged

update manifest4study file discrimination regex #187

merged 2 commits into from
Jun 28, 2021

Conversation

jmtcsngr
Copy link
Member

@jmtcsngr jmtcsngr commented Jun 22, 2021 •
edited
Loading

Part of #186

@jmtcsngr jmtcsngr requested review from ces and dkj June 22, 2021 11:55
@mgcam
Copy link
Member

mgcam commented Jun 22, 2021

Could you add an example to the Changes file?

dkj
dkj approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@dkj dkj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're relying on the pipeline only creating products for lane mergeable data i.e. no mixture of samples in a product. I think this is a pragmatic, low-risk, solution.

@jmtcsngr jmtcsngr merged commit 712c6a8 into wtsi-npg:devel Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkj dkj dkj approved these changes

@ces ces Awaiting requested review from ces

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmtcsngr @mgcam @dkj