Add register and token actions, improve message content and format #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Study rather study_id to build the message body. Fix missing domain argument. Bump npg-python-lib from 0.3.2 to 0.3.4
mgcam
requested changes
Nov 7, 2024
| "\n" | ||
| f"{path}\n" | ||
| "\n" | ||
| "This is an automated email from NPG. You are receiving it because you are registered\n" | ||
| "as a contact for one or more of the Studies listed below:\n" | ||
| "This is an automated email from NPG. You are receiving it because you are registered as a contact for one or more of the Studies listed below:\n" |
There was a problem hiding this comment.
Notifications for Illumina and PacBio platforms have a standard footer. Do we really want ONT notifications to be different?
There was a problem hiding this comment.
This one?
npg_notifications/src/npg_notify/mail.py
Lines 152 to 156 in 67a9abf
Yes, it's good for it to be the same.
There was a problem hiding this comment.
Yes. Lines 152-154 were added on request by SSRs
There was a problem hiding this comment.
I'm also expecting to add a few other details in the week or two after it's live - listing the plate barcodes and tag names/sequences.
mgcam
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Study rather study_id to build the message body.
Fix missing domain argument.
Bump npg-python-lib from 0.3.2 to 0.3.4