Create release 0.1.0 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial project scaffold
Run code checkers in CI
Imported a client script for interaction with the npg_porch server from an internal GitLab project. To avoid hardcoding pipeline details, created two additional script arguments, pipeline_url and pipeline_version. Replaced real token values with placeholders.
Updated project dependencies.
And configure flake8 in pyproject.toml
Copy script from gitlab project
Refactored the existing client script to use this API.
Created porch client API.
Do not use 'assert' for validation in the code.
API refactored to consolidate the logic about the action.
so that this method can be used by the code that uses other methods of this API.
Renamed _send_request to send_request
For the method to be useful outside this git package, the authorization should be optional. Simplified the error message in the method.
Tweaked and tested send_request method.
Extend error message
Following wtsi-npg/npg_porch#72, Status code 422 "Unprocessable Entity" error is received from the server if the status is not set.
Explicitly set the status of the new task.
Updated documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.