Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "create_token" action. #14

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Aug 2, 2024

Also fixed problems in the change log.

@mgcam mgcam requested a review from nerdstrike August 2, 2024 12:28
@mgcam mgcam force-pushed the add_token_action branch from 91751d3 to 410db27 Compare August 2, 2024 12:37
Copy link
Contributor

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a single typo. Everything else looks ok

CHANGELOG.md Outdated

The format is based on [Keep a Changelog](http://keepachangelog.com/).
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Added

* Implemented the `create_token` action. Provided the caller has na admin token,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/na/an/

Also fixed problems in the change log.
@mgcam mgcam force-pushed the add_token_action branch from 410db27 to e0e6f58 Compare August 2, 2024 13:24
@nerdstrike nerdstrike merged commit 023bb72 into wtsi-npg:devel Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants