This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
Flags for logging levels and logging to console #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 13, 2016 15:22
|
We might want to be even more flexible and to give an option to have either console logger or file logger or both. It would also be good to have a custom log file location/name. |
added 2 commits
December 16, 2016 17:03
There is a long-standing (multiple years) bug with winston that logging to file may not necessarily finish before a process.exit(). Avoid this by allowing logging to stderr, and expect users to redirect as necessary.
|
As in commit message in 7d61fa2 - the File transport in Winston will not always flush all the logs to the file before process.exit is called. Instead, we won't log to file (so no logs are lost), bu this means that we need to update deployment processes to redirect stderr to a logfile. |
Merged
|
Replaced by #153 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-L=<level>sets logging level-dsets logging level to 'debug' (highest level), overwriting-L--logconsolealso logs to console (default is not to log)Resolves #120