Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty (fix): Fix async REST response handling (Scala Future, error Rx) #3351

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

xerial
Copy link
Member

@xerial xerial commented Jan 22, 2024

  • Provide a thread manager in NettyServerConfig
  • Fix async request handling to properly catch the last response
  • Fix a blocking bug when REST API returns Future[_] response type

@github-actions github-actions bot added the internal Internal changes (usually non-user facing) label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1c91d6a) 82.55% compared to head (3bbea02) 82.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
+ Coverage   82.55%   82.56%   +0.01%     
==========================================
  Files         355      355              
  Lines       14892    14896       +4     
  Branches     2473     2446      -27     
==========================================
+ Hits        12294    12299       +5     
+ Misses       2598     2597       -1     
Files Coverage Δ
...la/wvlet/airframe/http/finagle/FinagleFilter.scala 94.44% <100.00%> (+0.32%) ⬆️
...la/wvlet/airframe/http/finagle/FinagleServer.scala 70.10% <ø> (ø)
.../scala/wvlet/airframe/http/netty/NettyServer.scala 87.50% <100.00%> (+0.15%) ⬆️
...t/airframe/http/client/JavaHttpClientChannel.scala 93.02% <ø> (ø)
...ame/http/router/HttpEndpointExecutionContext.scala 100.00% <100.00%> (ø)
...t/airframe/http/router/HttpRequestDispatcher.scala 89.18% <100.00%> (ø)
...scala/wvlet/airframe/http/client/AsyncClient.scala 94.87% <100.00%> (-0.13%) ⬇️
.../wvlet/airframe/http/client/HttpClientConfig.scala 60.00% <100.00%> (+1.37%) ⬆️
.../scala/wvlet/airframe/http/client/SyncClient.scala 97.29% <100.00%> (-0.08%) ⬇️
...scala/wvlet/airframe/http/client/HttpClients.scala 84.33% <50.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c91d6a...3bbea02. Read the comment docs.

@xerial xerial marked this pull request as ready for review January 23, 2024 08:05
@xerial xerial changed the title netty (internal): Add more REST tests netty (fix): Support scala.concurrent.Future responses in REST Jan 23, 2024
@xerial xerial changed the title netty (fix): Support scala.concurrent.Future responses in REST netty (fix): Fix async REST response handling (Scala Future, error Rx) Jan 23, 2024
@github-actions github-actions bot added the bug label Jan 23, 2024
@xerial xerial removed the internal Internal changes (usually non-user facing) label Jan 23, 2024
@xerial xerial enabled auto-merge (squash) January 23, 2024 08:16
@xerial xerial merged commit fa62a57 into main Jan 23, 2024
17 checks passed
@xerial xerial deleted the netty-rest-test branch January 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant