Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty (fix): Fix async REST response handling (Scala Future, error Rx) #3351

Merged
merged 7 commits into from
Jan 23, 2024

Remove unrelated changes

3bbea02
Select commit
Loading
Failed to load commit list.
Merged

netty (fix): Fix async REST response handling (Scala Future, error Rx) #3351

Remove unrelated changes
3bbea02
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2024 in 0s

82.56% (target 80.00%)

View this Pull Request on Codecov

82.56% (target 80.00%)

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1c91d6a) 82.55% compared to head (3bbea02) 82.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
+ Coverage   82.55%   82.56%   +0.01%     
==========================================
  Files         355      355              
  Lines       14892    14896       +4     
  Branches     2473     2446      -27     
==========================================
+ Hits        12294    12299       +5     
+ Misses       2598     2597       -1     
Files Coverage Δ
...la/wvlet/airframe/http/finagle/FinagleFilter.scala 94.44% <100.00%> (+0.32%) ⬆️
...la/wvlet/airframe/http/finagle/FinagleServer.scala 70.10% <ø> (ø)
.../scala/wvlet/airframe/http/netty/NettyServer.scala 87.50% <100.00%> (+0.15%) ⬆️
...t/airframe/http/client/JavaHttpClientChannel.scala 93.02% <ø> (ø)
...ame/http/router/HttpEndpointExecutionContext.scala 100.00% <100.00%> (ø)
...t/airframe/http/router/HttpRequestDispatcher.scala 89.18% <100.00%> (ø)
...scala/wvlet/airframe/http/client/AsyncClient.scala 94.87% <100.00%> (-0.13%) ⬇️
.../wvlet/airframe/http/client/HttpClientConfig.scala 60.00% <100.00%> (+1.37%) ⬆️
.../scala/wvlet/airframe/http/client/SyncClient.scala 97.29% <100.00%> (-0.08%) ⬇️
...scala/wvlet/airframe/http/client/HttpClients.scala 84.33% <50.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c91d6a...3bbea02. Read the comment docs.