Convert column DEFAULTs in CREATE TABLE statements
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanslade
reviewed
Dec 19, 2024
ryanslade
approved these changes
Dec 19, 2024
andrew-farries
force-pushed
the
convert-create-table-inline-check-constraints
branch
from
5f92000 to
5202eb9
Compare
andrew-farries
force-pushed
the
convert-create-table-inline-default
branch
from
a0d708e to
de07051
Compare
Base automatically changed from
convert-create-table-inline-check-constraints
to
main
December 19, 2024 13:10
andrew-farries
force-pushed
the
convert-create-table-inline-default
branch
from
de07051 to
042257a
Compare
Convert inline `DEFAULT` values in `CREATE TABLE` statements like this:
```sql
CREATE TABLE foo(a text DEFAULT 'foo')
```
into `OpCreateTable` operations like this:
```json
[
{
"create_table": {
"columns": [
{
"default": "'foo'",
"name": "a",
"nullable": true,
"type": "text"
}
],
"name": "foo"
}
}
]
```
andrew-farries
force-pushed
the
convert-create-table-inline-default
branch
from
042257a to
facf39f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert inline
DEFAULTvalues inCREATE TABLEstatements like this:into
OpCreateTableoperations like this:[ { "create_table": { "columns": [ { "default": "'foo'", "name": "a", "nullable": true, "type": "text" } ], "name": "foo" } } ]