README: fix example test_ext_sr.py run #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yann Dirson <[email protected]>
stormi
reviewed
Feb 29, 2024
| @@ -51,7 +51,7 @@ Refer to pytest's documentation or tutorials to understand how to start tests or | |||
|
|
|||
| Examples: | |||
| ``` | |||
| pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 | |||
| pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 --sr-disk=auto | |||
There was a problem hiding this comment.
Since --sr-disk=auto might cause unwanted data losses, maybe:
Suggested change
| pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 --sr-disk=auto | |
| pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 --sr-disk=[device (e.g "sdb") or "auto"] # this will erase anything present on the device |
stormi
reviewed
Feb 29, 2024
| @@ -51,7 +51,7 @@ Refer to pytest's documentation or tutorials to understand how to start tests or | |||
|
|
|||
| Examples: | |||
| ``` | |||
| pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 | |||
| pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 --sr-disk=auto | |||
| pytest tests/storage/zfs/test_zfs_sr_crosspool_migration.py --hosts=10.0.0.1,10.0.0.2 --vm=mini-linux-x86_64-uefi | |||
There was a problem hiding this comment.
--sr-disk is likely missing here too
There was a problem hiding this comment.
Did not try to run it yet, but at least that other test uses the standard description for required params, and does not mention it, so I thought it might in fact not :)
There was a problem hiding this comment.
I'm afraid it does require this param, as do all local storage tests that need a disk to create a SR on it
stormi
requested changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.