Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: fix example test_ext_sr.py run #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

README: fix example test_ext_sr.py run #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Refer to pytest's documentation or tutorials to understand how to start tests or

Examples:
```
pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1
pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 --sr-disk=auto
Copy link
Member

@stormi stormi Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since --sr-disk=auto might cause unwanted data losses, maybe:

Suggested change
pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 --sr-disk=auto
pytest tests/storage/ext/test_ext_sr.py --hosts=10.0.0.1 --sr-disk=[device (e.g "sdb") or "auto"] # this will erase anything present on the device

pytest tests/storage/zfs/test_zfs_sr_crosspool_migration.py --hosts=10.0.0.1,10.0.0.2 --vm=mini-linux-x86_64-uefi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sr-disk is likely missing here too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not try to run it yet, but at least that other test uses the standard description for required params, and does not mention it, so I thought it might in fact not :)

Copy link
Member

@stormi stormi Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid it does require this param, as do all local storage tests that need a disk to create a SR on it

pytest tests/misc/test_vm_basic_operations.py --hosts=10.0.0.1 --vm=mini-linux-x86_64-bios --vm=mini-linux-x86_64-uefi
```
Expand Down
Loading