CA-384191: Fix missing values for min VM restrictions #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CitrixChris
requested changes
Oct 24, 2023
- Min and max should also include the defaults when looking across all templates - Ensure exception isn't hit unnecessarily when parsing restriction value for VMs - Allow use of `GetRestrictionValueFromMatchingTemplate` with template objects - Parallelize `GetRestrictionValueAcrossTemplates` call Signed-off-by: Danilo Del Busso <[email protected]>
danilo-delbusso
force-pushed
the
bug/warning_label_CA-384191
branch
from
0bf2af1
to
08f15f8
Compare
CitrixChris
approved these changes
Oct 25, 2023
kc284
approved these changes
Oct 25, 2023
kc284
added
2 approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetRestrictionValueFromMatchingTemplatewith template objectsGetRestrictionValueAcrossTemplatescall